fix: **BREAKING** refactor frontmatter API #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotheroftux
approved these changes
Dec 17, 2024
src/transform/frontmatter.ts
Outdated
Comment on lines
59
to
61
| .replace(/^\s+/gm, '') | ||
| .replace(/\n/g, ' ') | ||
| .trim(); |
There was a problem hiding this comment.
I'd say we could use ts-dedent here as well, granted that we started using it again in our codebases
Comment on lines
+32
to
+46
| const matchMetadata = (fileContent: string) => { | ||
| if (!fileContent.startsWith(SEP)) { | ||
| return null; | ||
| } | ||
|
|
||
| const closeStart = fileContent.indexOf('\n' + SEP, SEP.length); | ||
| const closeEnd = fileContent.indexOf('\n', closeStart + 1); | ||
|
|
||
| if (closeStart === -1) { | ||
| return null; | ||
| } | ||
|
|
||
| return [fileContent.slice(SEP.length, closeStart).trim(), fileContent.slice(closeEnd + 1)]; | ||
| }; |
There was a problem hiding this comment.
Thanks for refactoring the regexp monstrosity, I was lazy to do the same :)
| const [metadata, strippedContent] = matches; | ||
|
|
||
| return [ | ||
| cloneDeepWith( |
There was a problem hiding this comment.
ok, this is a fair change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Убрал излишнюю декомпозицию из frontmatter.
Заменил основные методы на extractFrontMatter и composeFrontMatter.
composeFrontMatter совместим с extractFrontMatter по аргументам
Поменял логику обновления сурсмапов:
Большая пачка кода и тестов ушла из-за использования deepMergeWith