change MiniToc position in DOM #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add hyphen in aria-label value add Russian and English translation
replace div to nav tag replace div to h1 for title wrap MiniToc links into h2 and h3 tags
delete h2, h3 tags from MiniToc items delete aria-current from MiniToc items change h1 to h2 for MiniToc title wrap MiniToc title in div
change MiniToc position in DocLayout component use order property to remain MiniToc position in UI
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| &__left, | |||
| &__right { | |||
| order: 3; | |||
There was a problem hiding this comment.
Why is adding "order" property necessary ? Changing order in html is not enough?
There was a problem hiding this comment.
Changing order in html affects on focus order. But it also affects on Minitoc position in UI. Minitoc should be in the right side of layout and main content should be in the middle (Toc -> Main content -> MiniToc). Without "order" property MiniToc will be in the middle of layout and main content will be in the right side (Toc -> MiniToc -> Main content).
martyanovandrey
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change MiniToc position in DOM.
Task: https://github.com/orgs/diplodoc-platform/projects/2/views/1?pane=issue&itemId=55495812
Navigation order before: Toc -> Main content -> MiniToc
2024-07-16.12-08-14.mov
Navigation order after: Toc -> Minitoc -> Main content
2024-07-16.12-15-44.mov