fix: check if output parameter is located inside root #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotheroftux
approved these changes
Nov 18, 2024
|
|
||
| if (!writePath.startsWith(writeBasePath)) { | ||
| throw new UnarchiveIncluderError( | ||
| `Invalid output parameter: ${output}. Provide includer with output parameter, which is located inside the documentation`, |
There was a problem hiding this comment.
I'd say this error message is a bit confusing.
Maybe something along the lines of Expected the unarchive destination to be located inside project root, got: ${output}?
main-kun
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Agree with what @brotheroftux suggested, error message could be better
|
|
||
| if (!writePath.startsWith(writeBasePath)) { | ||
| throw new UnarchiveIncluderError( | ||
| `Invalid output parameter: ${output}. Provide includer with output parameter, which is located inside the documentation`, |
main-kun
approved these changes
Nov 18, 2024
martyanovandrey
force-pushed
the
unarchiveFix
branch
from
9792848 to
6c298a8
Compare
martyanovandrey
force-pushed
the
unarchiveFix
branch
from
6c298a8 to
bd3479f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.