feat: Add updatedAt field in metadata #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3y3
reviewed
Dec 27, 2023
| try { | ||
| contentIncludeFile = await readFile(relativeIncludeFilePath, 'utf8'); | ||
| } catch (err) { | ||
| if (err.code === 'ENOENT') { |
There was a problem hiding this comment.
Почему отсутствие файла в этом месте норма?
There was a problem hiding this comment.
Потому что мы собираем инклуды без учета условий из var переменных, как и в случае с авторами, это допущение
3y3
reviewed
Dec 27, 2023
src/vcs-connector/github.ts
Outdated
| const lines = part.trim().split(/\n/); | ||
| const committerDate = lines.shift(); | ||
| const unixtime = Number(committerDate); | ||
| for (let i = 0, len = lines.length; i < len; i++) { |
There was a problem hiding this comment.
ну.. можно и так, хотя for мне больше нравится
3y3
reviewed
Dec 27, 2023
src/vcs-connector/github.ts
Outdated
| ); | ||
|
|
||
| const parts = timeFiles.split(/\n\n/); | ||
| while (parts.length) { |
3y3
reviewed
Dec 27, 2023
src/services/metadata.ts
Outdated
|
|
||
| const relativeFilePath = tmpInputFilePath.substring(inputFolderPathLength + 1); | ||
|
|
||
| if (isContributorsEnabled && vcsConnector) { |
There was a problem hiding this comment.
Зачем основная логика под if, а в конце return undefined?
There was a problem hiding this comment.
да чет там было уже в функции выше, переделаю
3y3
approved these changes
Jan 9, 2024
Feverqwe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.