Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement TODO for <Triangle as Shape>::ccd_thickness #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

implement TODO for <Triangle as Shape>::ccd_thickness #9

wants to merge 2 commits into from

Conversation

LoganDark
Copy link

This is just about the lamest change I could make to qualify as a "contributor", but I saw this TODO and thought it was something I could implement so here it is.

cargo test passes of course.

@LoganDark
Copy link
Author

LoganDark commented Feb 21, 2021

Quick note, there are a few different things that TODO comment could have meant, such as:

  1. the minimum distance an object aimed at some part of the triangle would have to travel in order to make it through the triangle (so 0.0, naturally, because of the points)
  2. the diameter of the largest circle that could fit inside the triangle, which is an ok approximation of number 1 without the points causing it to always be 0
  3. the minimum side length
  4. some other estimate? maybe the minimum distance from an edge to a point?

I just went with 3, but it's totally okay if something else was intended. Let me know and I might be able to do that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant