add get_manager to django-cte #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
reviewed
Apr 1, 2021
|
@millerdev thanks for your review; I can add a simple unit test that verifies this new method looks up the default manager. |
|
Both seem like good tests. |
PaarthShah
reviewed
Apr 8, 2022
| """Get a manager for this model | ||
|
|
||
| The model's default_manager will be used by default. | ||
| This method may be over-riden to use custom managers |
There was a problem hiding this comment.
Suggested change
| This method may be over-riden to use custom managers | |
| This method may be overwritten to use custom managers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I think django-cte is great, but for my library use-case I want to force usage of the CTE manager even if the model has some other custom manager or if it has the default manager (i.e. I want to enable usage of CTEs on models outside of my control)
To help facilitate this, I think it would be nice if the logic for determining the manager were factored into a method on
Withso that it can be changed in a subclass or with monkey-patching.Thanks, let me know if this is something I should add tests for