Deploy history report #28133
Closed
Deploy history report #28133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(currently not implemented by Django)
[ci skip]
Use ES aliases instead of index names in queries
[ci skip]
esoergel
requested changes
Jul 23, 2020
corehq/apps/hqadmin/reports.py
Outdated
|
|
||
| @cached_property | ||
| def _user_lookup_url(self): | ||
| return reverse('web_deploy_lookup') |
There was a problem hiding this comment.
This method doesn't apply to this class - guessing it was copied over from the User List report.
corehq/apps/hqadmin/reports.py
Outdated
| def _format_date(self, date): | ||
| if date: | ||
| raw_time_since_deploy = dt.now() - date | ||
| delta_dict = self._strfdelta(raw_time_since_deploy) |
There was a problem hiding this comment.
It looks like this is a reimplementation of the naturaltime template filter. You can actually just call that directly as is done here:
commcare-hq/corehq/apps/export/views/list.py
Lines 316 to 317 in ef2fe26
corehq/apps/hqadmin/reports.py
Outdated
| return relative_time_formatted | ||
|
|
||
| def _hyperlink_diff_url(self, diff_url): | ||
| return '<a href="{link}">Diff with previous</a>'.format(link=diff_url) |
There was a problem hiding this comment.
Suggested change
| return '<a href="{link}">Diff with previous</a>'.format(link=diff_url) | |
| return f'<a href="{diff_url}">Diff with previous</a>' |
Happily, HQ is on python 3, so you can use f-strings!
…ions, use f-strings
AliRizvi1
requested review from
biyeun,
calellowitz,
dannyroberts,
kaapstorm,
millerdev,
mkangia,
orangejenny,
proteusvacuum,
Rohit25negi and
snopoke
as code owners
|
There are 367 errors:
|
|
Messed up a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27839
One feature of the above issue.
SUMMARY
Moved the Deploy History Report previously found on the 'System Info' admin page to its own standalone page. Part of a larger process of adding a commit field to the deploy history as explained in the above issue.
PRODUCT DESCRIPTION
Users will now be able to access the 'deploy history report' on its own standalone page.