Add PancakeGraph
#403
Add PancakeGraph
#403
Conversation
james-d-mitchell
force-pushed
the
pancake
branch
from
de88a27
to
4d98f96
Compare
This comment has been minimized.
This comment has been minimized.
james-d-mitchell
force-pushed
the
pancake
branch
from
4d98f96
to
742fd47
Compare
james-d-mitchell
force-pushed
the
pancake
branch
from
742fd47
to
5d6f25c
Compare
james-d-mitchell
force-pushed
the
pancake
branch
from
5d6f25c
to
48b4adf
Compare
|
@james-d-mitchell merge conflicts now should be resolved... |
gap/grape.gi
Outdated
| InstallMethod(CayleyDigraphCons, | ||
| "for IsMutableDigraph, group, and list of elements", | ||
| [IsMutableDigraph, IsGroup, IsHomogeneousList], | ||
| function(filt, G, gens) | ||
| if not IsFinite(G) then | ||
| ErrorNoReturn("the 1st argument <G> must be a finite group,"); |
There was a problem hiding this comment.
Here the arguments have the wrong indices if the function is called directly. Of course, this function is undocumented, but this raises the question (which may have already been answered) of whether it should be obscured using DIGRAPHS_
There was a problem hiding this comment.
They also have the wrong indices if CayleyDigraph is called with the filter as first argument.
tst/standard/grape.tst
Outdated
| gap> digraph := CayleyDigraph(IsMutableDigraph, group); | ||
| <mutable digraph with 8 vertices, 24 edges> | ||
| gap> digraph := CayleyDigraph(IsMutableDigraph, FreeGroup(1)); | ||
| Error, the 1st argument <G> must be a finite group, |
james-d-mitchell
force-pushed
the
pancake
branch
4 times, most recently
from
32a217f
to
95ec1bb
Compare
|
Just a reminder, there is a pull request on this branch about the burnt pancake graph (which has to do with signed permutations). I haven't finished documented it yet, but I guess I should do this and @james-d-mitchell should approve before merging this into master, if we still want burnt pancake as a family of graphs in digraphs :) |
james-d-mitchell
force-pushed
the
pancake
branch
2 times, most recently
from
2666a8f
to
fdb8832
Compare
doc/examples.xml
Outdated
| <Returns>A digraph.</Returns> | ||
| <Description> | ||
| If <A>n</A> is a positive integer, then this operation returns | ||
| the <E>Pancake graph</E> with <M>n!</M> vertices and <M>n!(n - 1)</M> |
There was a problem hiding this comment.
Looking great! Pancake should be pancake though (inappropriate capitalisation).
doc/examples.xml
Outdated
| <Description> | ||
| If <A>n</A> is a positive integer, then this operation returns | ||
| the <E>Pancake graph</E> with <M>n!</M> vertices and <M>n!(n - 1)</M> | ||
| directed edges. The <M>n</M>th Pancake graph is the Cayley graph of the |
There was a problem hiding this comment.
fixed in burnt pancake PR :)
|
|
||
| See <URL>https://en.wikipedia.org/wiki/Pancake_graph</URL> for further | ||
| details. | ||
|
|
There was a problem hiding this comment.
Is there documentation for the burnt pancake graph?
There was a problem hiding this comment.
@LRacine I have created a pull request on James's branch and if you would like to have a look I'd love to hear your comments :)
james-d-mitchell#14
There was a problem hiding this comment.
@marinaanagno Thank you, doing so now
james-d-mitchell
force-pushed
the
pancake
branch
from
f1cb6a1
to
2079807
Compare
|
Stale pull request message |
No description provided.