Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For PHP8+: Remove deprecated stylelint rule and rename PHPCS rule #195

Closed

Conversation

raikasdev
Copy link
Member

  • number-leading-zero rule was deprecated in Stylelint version 15.0.0 due to "pretty printing" features removed and focusing on linting itself. (Migrating to Prettier for SCSS linting?)
  • WordPress.WhiteSpace.PrecisionAlignment has been replaced by Universal.WhiteSpace.PrecisionAlignment in 3.0.0 (changelog entry)

@height
Copy link

height bot commented Sep 25, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@ronilaukkarinen
Copy link
Member

@raikasdev PHPCS fails to error ERROR: Referenced sniff "PHPCSUtils" does not exist. Can't get it to work on master or develop either, had to get -b 2.2.0. Strange. But unit test should go through, can you try and test it again? 🤔

@raikasdev
Copy link
Member Author

Ah, in 3.0.0 of the WordPress PHPCS rules PHPCSUtils was added as a dependency (might have been built-in before) and must be installed. I'll add them to the workflow, but they also need to be added to documentation (devpackages README also?)

3.0.0 is for PHP 8 support, so this PR isn't perhaps that critical right now, but as PHP 7.4 has reached end-of-life already and the WP team is trying to get PHP 8 full support released, probably good to have this ready.

"Dependencies on the following packages: PHPCSUtils, PHPCSExtra and the Composer PHPCS plugin."

@ronilaukkarinen ronilaukkarinen changed the title Remove deprecated stylelint rule and rename PHPCS rule For PHP8+: Remove deprecated stylelint rule and rename PHPCS rule Jan 10, 2024
@ronilaukkarinen
Copy link
Member

Added separately without this PR.

@raikasdev raikasdev deleted the fix/deprecated-linter-rules branch February 25, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants