Add maintenance day validation for database and kubernetes clusters #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreinhardt
commented
Dec 20, 2024
andrewsomething
requested changes
Dec 20, 2024
moreinhardt
force-pushed
the
add-maintenance-day-validation
branch
from
c831635 to
c5dd54e
Compare
moreinhardt
force-pushed
the
add-maintenance-day-validation
branch
from
c5dd54e to
7fe8510
Compare
moreinhardt
commented
Dec 21, 2024
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ValidateFunc: validation.StringInSlice([]string{"any", "monday", "tuesday", "wednesday", "thursday", "friday", "saturday", "sunday"}, true), |
There was a problem hiding this comment.
I don't have much experience with Go. I see that Go has no line length limit. So go fmt didn't complain or change this.
Should I wrap this to have every value on a separate line for readability?
There was a problem hiding this comment.
It's not something that is required in Go, but it is still often nice for readability. I've pushed a commit doing so since we've already made you wait too long on this.
andrewsomething
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs did not really tell me how to use this field.