Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for bearer_token auth #239

Merged
merged 2 commits into from
Jan 15, 2021
Merged

feat: add support for bearer_token auth #239

merged 2 commits into from
Jan 15, 2021

Conversation

mdanzinger
Copy link
Member

This PR adds support for scraping kube-state-metrics behind an authentication proxy (kube-rbac-proxy) by leveraging bearer token authentication.

Bearer tokens can either be passed in directly through the --bearer-token flag, or dynamically read with the --bearer-token-file flag.

#224

@mdanzinger mdanzinger requested a review from a team as a code owner January 14, 2021 04:48
go.mod Show resolved Hide resolved
Copy link
Contributor

@bsnyder788 bsnyder788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments / questions, but this looks really good otherwise!

Copy link
Contributor

@bsnyder788 bsnyder788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdanzinger mdanzinger merged commit 483d7a5 into master Jan 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/IN-3331 branch January 15, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants