Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransversingCSS module to allow tests with CSS selectors #1737

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amitaibu
Copy link
Collaborator

@amitaibu amitaibu commented Jul 2, 2023

fixes #1735

  1. Currently, it's a shameless copy/ paste from here and here
  2. It Would have been nicer if Yesod had exposed it as an importable package. Makes sense? If so, I'll open an issue there.
  3. html-conduit seems to be needed. Did I add it in the correct places? How to re-build IHP with this new package?

@mpscholten
Copy link
Member

It Would have been nicer if Yesod had exposed it as an importable package. Makes sense? If so, I'll open an issue there.

Yes, that seems useful to me 👍

html-conduit seems to be needed. Did I add it in the correct places? How to re-build IHP with this new package?

In ihp.nix it needs to be used somewhere else a bit lower in the file as well, so it should be two places where it's added in ihp.nix (once to declare it as the dependency at the top level of the file, and then somewhere in the file to actually use it)

@amitaibu
Copy link
Collaborator Author

Created issue on Yesod - yesodweb/yesod#1810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing helpers, add traversing over an HTML, and finding an element by CSS selector
2 participants