Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors of feedback list in dark mode #537

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Jun 12, 2024

Short description

This PR fixes the color conflict, which is a side effect of #515

Proposed changes

  • Introduce a new color assignment to feedback list in the dark mode

🤔 The contrast between "bold" and "normal" fonts is sadly not really visible enough in the dark mode (I can only slightly tell whether bold or normal). Should we use different font colors depend on the status (read/unread)? @hauf-toni

feedback list dark mode
This is how it looks after fix with this PR.

Resolved issues

Fixes: #532

@MizukiTemma MizukiTemma requested a review from a team as a code owner June 12, 2024 10:49
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix color assigment of feedback list rows in dark mode
2 participants