Initial 2.0 #286
Merged
Initial 2.0 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables will move to theme.
- Add theme variables for anchors - Update anchor color variable names - Move anchor transitions to theme styles
- Add theme variables for backgrounds - Update variable names for overlay background color
- Add theme variables for badges - Replace (some) core badge style values with variables
- Add theme variables for blockquotes - Replace (some) core blockquote style values with variables
- Add theme variables for body - Update body background-color variable names
- Add theme variables for code - Replace (some) code styles with variables - Remove commented out code
- Add theme variables for cards - Add core components for cards and move most card styles from theme - Replace (some) card styles with variables
- Add theme variables for marks - Remove core components for marks - Replace mark styles with variables
- Add theme variables for breadcrumbs - Move breadcrumbs components styles from theme to core - Replace (some) card styles with variables
- Update border-color variable name for greater consistency with other variable names - Add border-radius variables to theme
- Add theme variables for figures - Replace figcaption styles with variables - Remove commented out code
- Add theme variables for headings - Move most subhead styles from theme to core - Replace (some) heading styles with variables - Remove `display: block` from subheads (should be marked up with a <p> which is already a block element)
- Add theme variables for tables - Replace (some) table styles with variables
- Add theme variables for modals - Move most modal styles from theme to core - Replace (some) modals styles with variables
- Add theme variables for buttons - Move some button styles from theme to core, keeping buttons states to be styled in theme - Replace most button styles with variables
- Add theme variables for button groups - Move button group styles from theme to core - Replace some button group styles with variables
Restore `loading=“lazy”` for native lazy-loading.
- Update comments - Add variables, mixins and functions to deprecated.scss
- Remove empty line - Change double quotes to single quotes
- Do not automatically apply `opacity: 0` to lazy-loaded elements. Apply fade-in animation with `.dcf-fade-in` class instead - Add `dcf-fade-in` class to images in documentation - Remove `.dcf-fade-out` class until needed - Add inline JavaScript to replace `.no-js` class with `.js` - Use single quotes in inline JavaScript and update comments - Lazy load example images in table documentation - Update placeholder image URLs to https://
Remove until scroll-based animations are finalized in JavaScript and CSS.
- Remove `dcf-h-100% dcf-w-100%` from images using `dcf-obj-fit-cover`, `dcf-obj-fit-contain` or `dcf-obj-fit-none` which already set height and width. - Add width attribute equal to the largest image size in a `srcset` to images - Update image dimensions - Use repsonsive images in `<noscript>` versions
`<noscript>` versions will be shown instead.
- Move configuration to lazy load constructor - Remove configurable class names (e.g. `.dcf-fade-in`) to be added - Add/edit comments
Apply @jsturek’s updates to use `sizes` instead of `data-sizes` and calculate value if `sizes` is `auto` or empty (`null`).
- Use `sizes` instead of `data-sizes` - Change values in `<noscript>` sizes from `100vw` to `88vw` to account for the page wrapper. Images don’t fill the full width of the viewport.
# Conflicts: # assets/dist/js/app/common/dcf-modal.min.js.map # example/js/bundled/bundle.js.map
Prevent collapse of ratio elements when flexbox fallback is used for grid.
Prevent card content overflow when flexbox fallback is used for grid.
Use explicit closing tags instead of self-closing tags for SVG paths
|
In the interest of moving 2.0 work forward, let's go ahead and merge what's in the PR with the 2.0 branch. This code is still under active development and is not used in production anywhere. Any issues relating to code contained herein can be dealt with in follow-up issues/PRs. Regarding conflicts, it is my understanding that they result from changes to master that do not affect 2.0 work. As such, we can safely resolve the conflicts by accepting the versions from this PR. @skoolbus39 - Can you confirm? |
|
@macburgee1 Some are needed in 2.0; some aren't. I'll get them sorted and merged. |
# Conflicts: # assets/dist/js/app/common/dcf-modal.min.js # assets/dist/js/app/common/dcf-modal.min.js.map # core/dist/scss/generic/_generic.reduced-motion.scss # core/src/scss/generic/_generic.reduced-motion.scss # example/css/all.min.css # example/css/all.min.css.map # example/js/bundled/bundle.js.map
This will need to be moved to its own file when the JavaScript is rearchitected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js/no-jsclasses withdcf-Closes #12, closes #137, closes #195, closes #287, closes #288, closes #302