Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cloning. #25

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Skip cloning. #25

wants to merge 1 commit into from

Conversation

mattcollier
Copy link
Contributor

The use case is that there are artifact that need to be put into the npm package that are not created by any build script that is defined in the package.json file. Those artifacts also are not checked into the github repository. Therefore, if the repository is cloned, those files are absent and will not be included in the npm tarball.

I propose that we add another flag for --skip-clone that will replaces the fake conditional i've added here on L270.

@dmitrizagidulin
Copy link

+1, seems like a good addition. @mattcollier - what was the original usecase for cloning, anyways?

@dlongley
Copy link
Member

dlongley commented Dec 18, 2021

Definitely want this behind a flag. If there's a concern that something would go wrong without the flag -- perhaps we can detect something in those cases and prevent the publication from happening (and suggest that the user might need to set that flag). I imagine some bad things could happen if we move forward without the flag, potentially including some local secrets or cruft in published npm packages. This is just my initial reaction without putting much thought into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants