-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial files. #1
Conversation
- Patch jwk npm library. - Rename fromJsonWebKey2020 to handler in use method. - Remove requirement for algorithm and handler in use method. - Resolve DID document and key consistent with handler. - Write unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes are needed to use the latest JsonWebKey
stuff, but otherwise I can approve this as a baseline to get things kicked off.
@davidlehn, if you can look at the details more closely +1.
expect(didDocument.id).to.equal(did); | ||
expect(didDocument['@context']).to.eql([ | ||
'https://www.w3.org/ns/did/v1', | ||
'https://w3id.org/security/suites/jws-2020/v1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jws-2020 has been abandoned. The new context for a JsonWebKey is here: https://w3id.org/security/jwk/v1
It doesn't have a date in its type anymore either, just JsonWebKey
. You'll want to take a look at the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened #2 for this issue
I have resolved the linting issues and created an issue to update to use the latest version of |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok to accept this for a 1.0 release -- we can iterate from there with breaking changes as needed.
- Remove style changes.
No description provided.