chore: update backend native deps #896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the holepunch.to managed native deps to the latest versions, using the updated prebuilds.
|
@achou11 do you mind taking a look at this PR? |
yeah I had started looking at it yesterday. My understanding is that we probably don't want to integrate this for the upcoming release just yet so I de-prioritized. Is that accurate? EDIT: guess this could be merged into main without being part of the next release, but just a bit tedious to remember to not include this in the release branch, which is harder to do if using the release action trigger since it just uses the current state of the main branch (i think) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the holepunch.to managed native deps to the latest versions, using the updated prebuilds.
This also changes native module prebuilds from hard-coded versions to actually use the prebuild versions that match the dependencies.
I have tested this on in an emulator to check the app loads and I can create an observation, but I have not tested beyond that.
The dependency updates are all within semver, so there should be no breaking changes, however it would be good to update comapeo-core to the same versions and check all the tests pass.
This solves issues with these modules on x64, but x64 is still blocked by better-sqlite3 which is still broken on x64.