Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/implement testcontainers #235

Merged
merged 46 commits into from
Nov 19, 2024
Merged

Feat/implement testcontainers #235

merged 46 commits into from
Nov 19, 2024

Conversation

Ellenn-A
Copy link
Contributor

@Ellenn-A Ellenn-A commented Nov 11, 2024

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

https://digicatapult.atlassian.net/browse/VR-292

High level description

Implement testcontainers.

Detailed description

Implemented testcontainers, removing the need to docker build before running integration or e2e tests.

Describe alternatives you've considered

Operational impact

Additional context

@Ellenn-A Ellenn-A added v:minor Change requires a semver minor version change and removed v:minor Change requires a semver minor version change labels Nov 13, 2024
@Ellenn-A Ellenn-A added the v:minor Change requires a semver minor version change label Nov 15, 2024
@Ellenn-A Ellenn-A marked this pull request as ready for review November 18, 2024 11:01
@Ellenn-A Ellenn-A requested a review from a team as a code owner November 18, 2024 11:01
test/init.ts Outdated Show resolved Hide resolved
test/testcontainers/testcontainersSetup.ts Outdated Show resolved Hide resolved
test/integration/newConnection.test.ts Outdated Show resolved Hide resolved
@Ellenn-A Ellenn-A merged commit cb72c01 into main Nov 19, 2024
10 checks passed
@Ellenn-A Ellenn-A deleted the feat/implement-testcontainers branch November 19, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v:minor Change requires a semver minor version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants