New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: correct check for empty env var #9

Merged

renjith-digicat merged 2 commits into main from feature/dvc_with_aws_conn

Dec 4, 2024

+2 −2

Contributor

renjith-digicat commented Dec 3, 2024 •

edited

Loading

Pull Request

Checklist

Have you read Digital Catapult's Code of Conduct?
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.

PR Type

Bug Fix

Linked tickets

High level description

The check for empty environment variable was failing because the env variables are passed as empty strings instead of None.

Detailed description

Describe alternatives you've considered

Operational impact

Additional context

renjith-digicat added 2 commits

December 3, 2024 16:19


          bugfix: correct check for empty env var

6f526fc


          increment version

renjith-digicat requested a review from dblane-digicatapult

December 3, 2024 16:21

dblane-digicatapult approved these changes

View reviewed changes

renjith-digicat merged commit 95adf2f into main

5 checks passed

renjith-digicat deleted the feature/dvc_with_aws_conn branch

December 4, 2024 08:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet