Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Radio+Checkbox): use input component #2607

Open
wants to merge 24 commits into
base: next
Choose a base branch
from

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Oct 11, 2024

@eirikbacker eirikbacker self-assigned this Oct 11, 2024
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 86c4a6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Preview deployments for this pull request:

Storybook - 23. Oct 2024 - 13:22

Theme - 23. Oct 2024 - 13:23

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 56.13% 3384 / 6028
🔵 Statements 56.13% 3384 / 6028
🔵 Functions 84.69% 166 / 196
🔵 Branches 75.07% 479 / 638
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/form/useFormField.ts 100% 100% 100% 100%
packages/react/src/components/form/Checkbox/Checkbox.tsx 100% 66.66% 100% 100%
packages/react/src/components/form/Checkbox/useCheckbox.ts 0% 100% 100% 0% 2-4
packages/react/src/components/form/Fieldset/Fieldset.tsx 100% 87.5% 100% 100%
packages/react/src/components/form/Fieldset/FieldsetContext.ts 100% 100% 100% 100%
packages/react/src/components/form/Input/Input.tsx 100% 100% 100% 100%
packages/react/src/components/form/Radio/Radio.tsx 100% 75% 100% 100%
packages/react/src/components/form/Switch/useSwitch.ts 80% 50% 100% 80% 45-47, 52-54
Generated in workflow #527 for commit 86c4a6d by the Vitest Coverage Report Action

@eirikbacker eirikbacker changed the title fix(Radio): use input component fix(Radio+Checkbox): use input component Oct 18, 2024
packages/css/field.css Outdated Show resolved Hide resolved
@eirikbacker eirikbacker marked this pull request as ready for review October 23, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 Ready for review
Development

Successfully merging this pull request may close these issues.

Topp align checkbox and radio
1 participant