-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Field): start implementing field api #2502
Conversation
🦋 Changeset detectedLatest commit: c339c1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
We should probably have a changeset for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small stuff on code readability.
This is a good starting point for us to start using, and we'll just tweak going forward.
I also updated #2311 CharacterCounter
so we don't forget we need to figure out how to solve that.
Fixes #1943
For now just testing creating a
<Field>
component, which uses a utility that works with the real DOM, making it possible to use in a future custom element<ds-field>
as well. This also allows injecting any form element - not just made by us, but any native form element, any form associated custom element or third party components.By using native DOM, there is no
Context
that needs to run on server, and all the wire-up is only for assistive technology - it does not effect the visual representation, meaning it can be done under the hood on the client without causing any layout shift or similar issues.API: