-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes from IBOIS's dry run #131
Conversation
…they are a part of
rh_mesh_target_list = [] | ||
for joint in i_assembly.all_joints: | ||
for face in joint.faces: | ||
face = face.to_mesh() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment here and perhaps not directly related to the PR.. for the case of beam or joint we are using the joint.to_mesh()
and beam.to_mesh()
that get the input of the MaximumEdgeLength
which the user directly changes from the inputs of the Component. This is not the case now for the case where we evaluate the face of each joint where Rhino.Geometry.MeshingParameters.QualityRenderMesh
is always used.
I believe Normal Segmentator and Colorize Cloud are still red when dropped on the canvas, otherwise no complaints. |
Would you be able to add a commit to fix this with the btw @eleni I am almost finished with the refactored that you might want to test, I still have it for a couple of hours..I'll pop a message here! |
Okie. Done ✔️ In case the checks fail me, let the record show that I tried.. |
…r the computation of error
…heck into dry_run_ibois
@eleniv3d mesh swap is also fine! |
…g computing error comp
…heck into dry_run_ibois
description
This PR introduces small fixes while testing the subtractive chapter and pipeline from IBOIS's side.
fixes
DF_build_assembly
,DF_cloud_voxel_downsample
,DF_cloud_size_downsample
,DF_cloud_normal_estimator
and many others as dropped on the canvasmean
value to all the error compute, visualizer and csv exporter