Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from IBOIS's dry run #131

Merged
merged 45 commits into from
Oct 4, 2024
Merged

Fixes from IBOIS's dry run #131

merged 45 commits into from
Oct 4, 2024

Conversation

9and3
Copy link
Contributor

@9and3 9and3 commented Sep 30, 2024

description

This PR introduces small fixes while testing the subtractive chapter and pipeline from IBOIS's side.

fixes

  • no more error for the DF_build_assembly, DF_cloud_voxel_downsample, DF_cloud_size_downsample, DF_cloud_normal_estimator and many others as dropped on the canvas
  • the assembly preview is been fixed and it is now working for single beams
  • added the mean value to all the error compute, visualizer and csv exporter

9and3 and others added 25 commits September 30, 2024 17:17
rh_mesh_target_list = []
for joint in i_assembly.all_joints:
for face in joint.faces:
face = face.to_mesh()
Copy link
Collaborator

@eleniv3d eleniv3d Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment here and perhaps not directly related to the PR.. for the case of beam or joint we are using the joint.to_mesh() and beam.to_mesh() that get the input of the MaximumEdgeLength which the user directly changes from the inputs of the Component. This is not the case now for the case where we evaluate the face of each joint where Rhino.Geometry.MeshingParameters.QualityRenderMesh is always used.

@eleniv3d
Copy link
Collaborator

eleniv3d commented Oct 3, 2024

I believe Normal Segmentator and Colorize Cloud are still red when dropped on the canvas, otherwise no complaints.

@9and3
Copy link
Contributor Author

9and3 commented Oct 3, 2024

I believe Normal Segmentator and Colorize Cloud are still red when dropped on the canvas, otherwise no complaints.

Would you be able to add a commit to fix this with the if.. catch at the beginning plis? Thanks 👐

btw @eleni I am almost finished with the refactored that you might want to test, I still have it for a couple of hours..I'll pop a message here!

@eleniv3d
Copy link
Collaborator

eleniv3d commented Oct 3, 2024

I believe Normal Segmentator and Colorize Cloud are still red when dropped on the canvas, otherwise no complaints.

Would you be able to add a commit to fix this with the if.. catch at the beginning plis? Thanks 👐

btw @eleni I am almost finished with the refactored that you might want to test, I still have it for a couple of hours..I'll pop a message here!

Okie. Done ✔️

In case the checks fail me, let the record show that I tried..

Screenshot 2024-10-03 154457

@9and3
Copy link
Contributor Author

9and3 commented Oct 3, 2024

Ok I pushed the refactor components and corresponding Python API for the components: computer-error, visualization and csv exporter.

I'll try to resume what we changed: basically the problem came from the fact that for joins if one was veeery far or there was a missing cloud (due to missing points in the scan) we were not able to establish this. Now we are.
The mechanism is quite simple, we mark the rh_cloud with a string indicating the sanity of it (0=good, 1=too_far, 2=missing_points). In this way the results are not contaminated by clouds that we consider really off.

In the followin image the 0-2 joint is detected as way too far (the scan is on the bottom of the image.
image

image

Important:

  • this was tested with subtractive pipeline and it works
  • the swap in the compute error component is not working for now (I am on it)
  • this should be tested with the assembly

@9and3
Copy link
Contributor Author

9and3 commented Oct 3, 2024

In case the checks fail me, let the record show that I tried..

the hereby CI jury has emitted a "not guilty" output

image

@9and3
Copy link
Contributor Author

9and3 commented Oct 3, 2024

@eleniv3d mesh swap is also fine!

@9and3 9and3 marked this pull request as ready for review October 4, 2024 15:25
@9and3 9and3 merged commit 8d1a436 into main Oct 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants