Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidating client is not removed from the list of clients holding the invalidated key #192

Merged

Conversation

dmercuriali
Copy link
Contributor

  • added some concurrency tests for load / fetch / invalidate

  • while testing i realized that the client which requested an invalidate was not removed (server-side) from the list of clients holding the invalidated key. I think this can lead to fetch related problems since we always fetch from a single client, no matter the response

  • since we always fetch from a single client, I simplified the server-side fetch. There was no reason to sort the list of clients and iterate over it just to break after the first loop

  • I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

@dmercuriali dmercuriali self-assigned this Jan 5, 2024
Copy link
Contributor

@diegosalvi diegosalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding tests on invalidation

@diegosalvi diegosalvi merged commit f744b3d into diennea:master Jan 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants