Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add basic E2E tests #2628

Merged
merged 1 commit into from
Feb 9, 2024
Merged

chore: add basic E2E tests #2628

merged 1 commit into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. chore: add basic E2E tests

    This proposal adds E2E tests. It runs these tests on Node.js 18, 20, and 21 (so just like unit tests), in CJS and ESM mode.
    
    Each test creates a stupid simple and compares it to reference PDF file stored inside the repository. It's purposefully minimal: the aim of these E2E tests is to catch any bugs that would break module resolution on different Node.js environments, rather than test advanced react-pdf rendering features, which is beautifully done in unit tests already.
    
    Would have prevented #2602, #2608.
    
    Will prevent any future issues with module resolution caused by e.g. dependency updates or Rollup config updates.
    
    Closes #2611
    
    PS. I'm considering another E2E test that would spin up Vite-based front-end application, opens it using Playwright and does a similar comparison, although that's a bit too much work for me at the moment.
    wojtekmaj committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e7235d8 View commit details
    Browse the repository at this point in the history