feat: pass _INTERNAL__LAYOUT__DATA_ to onRenderCallback in toBuffer #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already passed in toBlob, but the APIs aren't unified for other methods. I have the same use case as diegomura#2201, but I'm in Node not the browser.
🦋 Changeset detectedLatest commit: 200cf66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
If images are inside of view render fucntions, their sources aren't filled in, so rendering them fails. Processing assets a second time fixes this. diegomura#2637
diegomura
changed the title
mskec
pushed a commit
to mskec/react-pdf
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already passed in toBlob, but the APIs aren't unified for other methods. I have the same use case as #2201, but I'm in Node not the browser.