fix: fix require @react-pdf/primitives from CJS #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 894ebdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wojtekmaj
force-pushed
the
fix-primitives
branch
from
69b5ce4
to
894ebdf
Compare
|
arfff thx i didn't figure out why i have esm errors in my project 👍 |
|
No need to thank me, I was the one to mess it up in the first place 🤣 |
|
Yeah i saw that ^^ you managed to broke an +13k⭐️ project for few hours. It's happen sometimes ^^ |
|
Carret is fine, unless you fail to commit your lockfile, which you definitely should. |
mskec
pushed a commit
to mskec/react-pdf
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2409 I missed changing the extension of CJS code to .cjs, resulting in (inaccurate) ERR_REQUIRE_ESM error thrown in Node in CJS environment.