fix: linting (#2479)

* fix: linting * chore: add changeset
diegomura · Jan 14, 2024 · 45b2bd3 · 45b2bd3
1 parent 8b00577
commit 45b2bd3
Show file tree

Hide file tree

Showing 32 changed files with 1,809 additions and 1,835 deletions.
diff --git a/.changeset/gorgeous-dragons-brake.md b/.changeset/gorgeous-dragons-brake.md
@@ -0,0 +1,10 @@
+---
+'@react-pdf/examples': patch
+'@react-pdf/textkit': patch
+'@react-pdf/layout': patch
+'@react-pdf/pdfkit': patch
+'@react-pdf/image': patch
+'@react-pdf/yoga': patch
+---
+
+fix linting
diff --git a/.eslintignore b/.eslintignore
@@ -2,3 +2,4 @@
 node_modules
 lib
 rollup.config.js
+packages/yoga/dist
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -27,6 +27,7 @@ module.exports = {
   },
   plugins: ['react', 'jest'],
   rules: {
+    'func-names': 0,
     'no-continue': 1,
     'no-cond-assign': 1,
     'react/prop-types': 0,
@@ -37,7 +38,7 @@ module.exports = {
     'import/no-named-as-default': 0,
     'react/state-in-constructor': 0,
     'react/jsx-filename-extension': 0,
-    'react/jsx-props-no-spreading': 1,
+    'react/jsx-props-no-spreading': 0,
     'react/destructuring-assignment': 0,
   },
 };
diff --git a/packages/examples/src/fractals/Fractal.js b/packages/examples/src/fractals/Fractal.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Text, View, StyleSheet } from '@react-pdf/renderer';
 
 const palette = [

diff --git a/packages/examples/src/fractals/index.js b/packages/examples/src/fractals/index.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Page, Document } from '@react-pdf/renderer';
 
 import Fractal from './Fractal';

diff --git a/packages/examples/src/goTo/index.js b/packages/examples/src/goTo/index.js
@@ -1,7 +1,3 @@
-/* eslint react/prop-types: 0, react/jsx-sort-props: 0 */
-
-import React from 'react';
-
 import { Page, Document, Link, View, Image } from '@react-pdf/renderer';
 
 export default () => (

diff --git a/packages/examples/src/index.js b/packages/examples/src/index.js
@@ -1,6 +1,4 @@
-import './index.css';
-
-import React, { useState } from 'react';
+import { useState } from 'react';
 import ReactDOM from 'react-dom';
 import { PDFViewer } from '@react-pdf/renderer';
 

diff --git a/packages/examples/src/knobs/index.js b/packages/examples/src/knobs/index.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Document, Page, View, Text, StyleSheet } from '@react-pdf/renderer';
 
 const styles = StyleSheet.create({

diff --git a/packages/examples/src/mediaQueries/index.js b/packages/examples/src/mediaQueries/index.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Document, Page, View, StyleSheet } from '@react-pdf/renderer';
 
 const styles = StyleSheet.create({

diff --git a/packages/examples/src/pageWrap/index.js b/packages/examples/src/pageWrap/index.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import {
   Document,
   Font,

diff --git a/packages/examples/src/resume/Education.js b/packages/examples/src/resume/Education.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Text, View, StyleSheet } from '@react-pdf/renderer';
 
 import Title from './Title';

diff --git a/packages/examples/src/resume/Experience.js b/packages/examples/src/resume/Experience.js
@@ -1,6 +1,3 @@
-/* eslint-disable react/no-array-index-key */
-
-import React from 'react';
 import { Text, View, StyleSheet } from '@react-pdf/renderer';
 
 import Title from './Title';
@@ -77,8 +74,8 @@ const ExperienceEntry = ({ company, details, position, date }) => {
         </View>
       </View>
       <List>
-        {details.map((detail, i) => (
-          <Item key={i} style={styles.detailContainer}>
+        {details.map(detail => (
+          <Item key={detail.company} style={styles.detailContainer}>
             {detail}
           </Item>
         ))}

diff --git a/packages/examples/src/resume/Header.js b/packages/examples/src/resume/Header.js
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import { Link, Text, View, StyleSheet } from '@react-pdf/renderer';
 
 const styles = StyleSheet.create({

diff --git a/packages/examples/src/resume/List.js b/packages/examples/src/resume/List.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Text, View, StyleSheet } from '@react-pdf/renderer';
 
 const styles = StyleSheet.create({

diff --git a/packages/examples/src/resume/Skills.js b/packages/examples/src/resume/Skills.js
@@ -1,6 +1,3 @@
-/* eslint-disable react/no-array-index-key */
-
-import React from 'react';
 import { Text, View, StyleSheet } from '@react-pdf/renderer';
 
 import Title from './Title';
@@ -23,8 +20,8 @@ const SkillEntry = ({ name, skills }) => (
   <View>
     <Text style={styles.title}>{name}</Text>
     <List>
-      {skills.map((skill, i) => (
-        <Item key={i}>{skill}</Item>
+      {skills.map(skill => (
+        <Item key={skill}>{skill}</Item>
       ))}
     </List>
   </View>

diff --git a/packages/examples/src/resume/Title.js b/packages/examples/src/resume/Title.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Text, StyleSheet } from '@react-pdf/renderer';
 
 const styles = StyleSheet.create({

diff --git a/packages/examples/src/resume/index.js b/packages/examples/src/resume/index.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import {
   Text,
   Font,

diff --git a/packages/examples/src/svg/Heart.js b/packages/examples/src/svg/Heart.js
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import { Svg, G, Path } from '@react-pdf/renderer';
 
 const Heart = () => (

diff --git a/packages/examples/src/svg/Svg1.js b/packages/examples/src/svg/Svg1.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Rect, Svg, G, Path, Text, Tspan } from '@react-pdf/renderer';
 
 const Svg1 = () => (

diff --git a/packages/examples/src/svg/Svg2.js b/packages/examples/src/svg/Svg2.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import {
   Rect,
   Svg,

diff --git a/packages/examples/src/svg/Svg4.js b/packages/examples/src/svg/Svg4.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import {
   Svg,
   Stop,

diff --git a/packages/examples/src/svg/svg.js b/packages/examples/src/svg/svg.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Svg, G, Polygon } from '@react-pdf/renderer';
 
 const Tiger = () => (

diff --git a/packages/examples/src/text/index.js b/packages/examples/src/text/index.js
@@ -1,6 +1,5 @@
 /* eslint-disable jsx-a11y/anchor-is-valid */
 
-import React from 'react';
 import {
   Document,
   Page,

diff --git a/packages/image/src/png.js b/packages/image/src/png.js
@@ -1,6 +1,6 @@
 import PNG from '@react-pdf/png-js';
 
-PNG.isValid = function(data) {
+PNG.isValid = function isValid(data) {
   try {
     return !!new PNG(data);
   } catch (e) {

diff --git a/packages/layout/src/steps/resolvePagination.js b/packages/layout/src/steps/resolvePagination.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-use-before-define */
 /* eslint-disable no-continue */
 /* eslint-disable prefer-destructuring */
 

diff --git a/packages/pdfkit/src/font/afm.js b/packages/pdfkit/src/font/afm.js
@@ -1,3 +1,6 @@
+/* eslint-disable no-var */
+/* eslint-disable no-cond-assign */
+
 import fs from 'fs';
 import range from '../utils/range';
 

diff --git a/packages/pdfkit/src/font/embedded.js b/packages/pdfkit/src/font/embedded.js
@@ -1,3 +1,5 @@
+/* eslint-disable no-cond-assign */
+// eslint-disable-next-line no-unused-vars
 import PDFObject from '../object';
 
 const toHex = function(...codePoints) {
@@ -77,7 +79,7 @@ const createEmbeddedFont = PDFFont =>
       let last = 0;
       let index = 0;
       while (index <= text.length) {
-        var needle;
+        let needle;
         if (
           (index === text.length && last < index) ||
           ((needle = text.charAt(index)), [' ', '\t'].includes(needle))
@@ -177,7 +179,7 @@ const createEmbeddedFont = PDFFont =>
 
       // generate a random tag (6 uppercase letters. 65 is the char code for 'A')
       const tag = [0, 1, 2, 3, 4, 5]
-        .map(i => String.fromCharCode(Math.random() * 26 + 65))
+        .map(() => String.fromCharCode(Math.random() * 26 + 65))
         .join('');
       const name = tag + '+' + this.font.postscriptName;
 

diff --git a/packages/textkit/src/attributedString/copy.js b/packages/textkit/src/attributedString/copy.js