Test broken with upcoming ggplot2

[teunbrand]

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break tidyterra.

The gist of the breakage is that we've added layout in a different way to plots that breaks a plot equality test in tidyterra. In this PR, we remove the layouts before testing for equality.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help tidyterra get out a fix if necessary.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d011f4d) 99.57% compared to head (deb87c9) 99.57%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          44       44           
  Lines        2575     2575           
=======================================
  Hits         2564     2564           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dieghernan]

Thanks for the PR, I would try to send a new release to CRAN early next week.

[teunbrand]

Thanks for the prompt response!

[dieghernan]

Just to confirm, running on my machine

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))
devtools::check(cran = TRUE, manual = TRUE)

gives

── R CMD check results ─────────────────────────── tidyterra 0.5.1.9000 ────
Duration: 13m 9.2s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

[teunbrand]

Good, that soothes the soul :)

[dieghernan]

HI @teunbrand

tidyterra 0.5.2 is already on CRAN, I checked once again and no hiccups:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))
devtools::check(cran = TRUE, manual = TRUE)

[teunbrand]

Awesome, that is quick!