normalize labels in metric matcher

didww · Nov 29, 2023 · d1466fc · d1466fc
1 parent bad109f
commit d1466fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/prometheus_exporter/ext/rspec/metric_matcher.rb b/lib/prometheus_exporter/ext/rspec/metric_matcher.rb
@@ -27,7 +27,9 @@ def matches?(actual)
 
       return false unless values_match?(metric_class, actual.class)
       return false unless values_match?(metric_name, actual.name.to_s)
-      return false if !metric_payload.nil? && !values_match?(metric_payload, actual.to_h)
+
+      actual_payload = actual.to_h.transform_keys { |labels| labels.transform_keys(&:to_s) }
+      return false if !metric_payload.nil? && !values_match?(metric_payload, actual_payload)
 
       true
     end

diff --git a/spec/prometheus_exporter/ext/metric/gauge_with_time_spec.rb b/spec/prometheus_exporter/ext/metric/gauge_with_time_spec.rb
@@ -76,14 +76,14 @@
       before do
         metric.observe(1, 'foo' => 'bar')
         sleep 0.2
-        metric.observe(2, 'baz' => 'boo')
+        metric.observe(2, baz: 'boo')
       end
 
       it 'has correct to_h' do
         expect(metric.to_h).to match(
           {
             { 'foo' => 'bar' } => [1, ms_since_epoch],
-            { 'baz' => 'boo' } => [2, ms_since_epoch]
+            { baz: 'boo' } => [2, ms_since_epoch]
           }
         )
       end