Enhancement: add VR support #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fivell
reviewed
Aug 14, 2023
| [Visa](http://en.wikipedia.org/wiki/Visa_Inc.) | :visa | ||
| [Switch](http://en.wikipedia.org/wiki/Switch_(debit_card)) | :switch | ||
| [Visa](http://en.wikipedia.org/wiki/Visa_Inc.) | :visa | ||
| [VR Alimentação](https://www.vr.com.br/) | :vr_alimentacao |
There was a problem hiding this comment.
@guizaols can you please explain what is the difference between this brands , isn't it 1 single brand to validate, what are use cases to have 3 different types and not only 1 vr
Fivell
reviewed
Aug 14, 2023
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| describe 'Except Amex and Maestro brand' do | |||
| it 'should reject all other valid numbers' do | |||
| VALID_NUMBERS.except(:amex, :maestro).each do |_, numbers| | |||
| VALID_NUMBERS.except(:amex, :maestro, :vr_refeicao).each do |_, numbers| | |||
There was a problem hiding this comment.
describe 'Except Amex and Maestro brand' now is not reflecting real test, also there is new describe block below
describe 'Only Amex and Mestro brands' that is testing opposite behaviour of this describe block
maybe it is better just to remove this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.