Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catppuccin Themes (v4) #562

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Add Catppuccin Themes (v4) #562

merged 9 commits into from
Nov 14, 2024

Conversation

cswimr
Copy link
Contributor

@cswimr cswimr commented Jun 10, 2024

This PR adds Catppuccin themes (the same ones from my previous v3 pr) to v4.

image
image
image
image

@cswimr cswimr marked this pull request as ready for review June 10, 2024 01:14
@cswimr
Copy link
Contributor Author

cswimr commented Jun 10, 2024

Just realized I made the same mistake as I did on the original pr with the light theme, fixing real quick

@cswimr
Copy link
Contributor Author

cswimr commented Jun 10, 2024

Ok, I think a bit more work would be required to get Latte working properly, some elements (notably the profile dropdown in the top right) aren't readable and also aren't being themed properly.
image
I'll commit the current version of Latte that I'm testing, because it is closer to the intended theme, but it's not ready for merging yet. Assistance on this would be appreciated.

@cswimr cswimr marked this pull request as draft June 10, 2024 01:29
@diced diced added feature A feature you would like to be added into Zipline! v4 v4 bugs labels Sep 6, 2024
@diced
Copy link
Owner

diced commented Nov 14, 2024

I think the issue was that you set the colorScheme for the latte theme as dark instead of light. A quick look at the theme tells me that it should be a light theme instead of a dark theme since most of the colors are lighter. I think some of the colors do need some work, since it doesn't look quite right yet.

Since this is one of the first light themes that doesn't use the default #FFF colors it might be a bit finicky so let me know here or on discord if there are any issues still.

colorScheme: light
image

colorScheme: dark
image

After this, I realized this was the only custom "light" theme and went to figure out how mantine handled this (so you wouldn't be wasting any time), and came up with this theme that seems to work and look good to me, although I'm not sure if I followed Catppuccin's guidelines

{
  "name": "Catppuccin Latte",
  "colorScheme": "light",
  "colors": {
    "blue": [
      "#FFFFFF",
      "#3676f6",
      "#0a57ee",
      "#094ed6",
      "#1d42f5",
      "#1d54f5",
      "#1d65f5",
      "#1d77f5",
      "#1d89f5",
      "#1e66f5"
    ],
    "gray": [
      "#ccd0da",
      "#ccd0da",
      "#9ca0b0",
      "#ccd0da",
      "#acb0be",
      "#bcc0cc",
      "#5c5f77",
      "#eff1f5",
      "#e6e9ef",
      "#dce0e8"
    ]
  },
  "white": "#eff1f5",
  "primaryColor": "blue",
  "mainBackgroundColor": "#e6e9ef"
}

Here's how it looks:
image

@diced diced marked this pull request as ready for review November 14, 2024 21:57
@diced diced merged commit 49269f7 into diced:v4 Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature you would like to be added into Zipline! v4 v4 bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants