Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MimeType and Attach #288

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Fix MimeType and Attach #288

merged 5 commits into from
Jul 20, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jul 20, 2023

Description

This PR add two changes:

  • Fix mime types
  • Add attachment data:
    image

Also, I needed change the struct to support that:

image

RGB-Wallet PR:
RGB-WG/rgb-std#89

@crisdut crisdut added bug Something isn't working enhancement New feature or request rgb labels Jul 20, 2023
@crisdut crisdut added this to the 0.6.1 milestone Jul 20, 2023
@crisdut crisdut requested a review from cryptoquick July 20, 2023 02:58
@crisdut crisdut self-assigned this Jul 20, 2023
@crisdut crisdut changed the title Fix Media ty and Attach Fix MimeType and Attach Jul 20, 2023
cryptoquick
cryptoquick approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cryptoquick cryptoquick added this pull request to the merge queue Jul 20, 2023
Merged via the queue into development with commit 39884d8 Jul 20, 2023
5 checks passed
@cryptoquick cryptoquick deleted the CD/fix-media-and-add-attach branch July 25, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@josediegorobles josediegorobles Awaiting requested review from josediegorobles

Assignees

@crisdut crisdut

Labels
bug Something isn't working enhancement New feature or request rgb
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@crisdut @cryptoquick