Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put package version into .info files #1260

Merged
merged 7 commits into from
Jun 23, 2016
Merged

Put package version into .info files #1260

merged 7 commits into from
Jun 23, 2016

Conversation

kdm9
Copy link
Contributor

@kdm9 kdm9 commented Aug 17, 2015

As discussed in #1254

@mr-c mr-c added this to the 2.0+ milestone Aug 18, 2015
@kdm9 kdm9 force-pushed the feat/coungraph-info branch from 5c66149 to 0aa86f5 Compare February 15, 2016 18:32
@kdm9
Copy link
Contributor Author

kdm9 commented Feb 15, 2016

This is ready for review, I think.

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)
  • Is the Copyright year up to date?

@kdm9
Copy link
Contributor Author

kdm9 commented Feb 15, 2016

jenkins, retest this please.

@kdm9
Copy link
Contributor Author

kdm9 commented Feb 15, 2016

Tests pass locally but for a CPython bug, though Jenkins seems to have chucked another wobbly.

@codecov-io
Copy link

Current coverage is 90.65%

Merging #1260 into master will increase coverage by <.01%

@@             master      #1260   diff @@
==========================================
  Files            57         57          
  Lines          7128       7129     +1   
  Methods           0          0          
  Messages          0          0          
  Branches        427        426     -1   
==========================================
+ Hits           6462       6463     +1   
- Misses          597        598     +1   
+ Partials         69         68     -1   

Powered by Codecov. Last updated by a802fea...512f86d

@standage
Copy link
Member

Tests pass after merging latest master.

@ctb
Copy link
Member

ctb commented Jun 23, 2016

@standage looks great! Please feel free to merge other people's commits ;).

@ctb
Copy link
Member

ctb commented Jun 23, 2016

thanks @kdmurray91

@ctb ctb merged commit a9d8d1a into master Jun 23, 2016
@ctb ctb deleted the feat/coungraph-info branch June 23, 2016 14:30
Dmarch28 pushed a commit to Dmarch28/khmer that referenced this pull request Mar 10, 2021
* load-into-coungraph.py: put version into .info

* be consistent with variable names

* Fix info file variable name

* Document dib-lab#1260 in CL

* Bump copyright year of load-into-counting.py

Per checklist item

* Add test for load-into-counting info version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants