Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUGFIX a handful of OOB #1844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add BUGFIX a handful of OOB #1844

wants to merge 1 commit into from

Conversation

AJenbo
Copy link
Member

@AJenbo AJenbo commented Nov 7, 2019

No description provided.

Source/drlg_l3.cpp Outdated Show resolved Hide resolved
@@ -423,18 +423,19 @@ static void DRLG_L3River()
rx = 0;
ry = 0;
i = 0;
while ((dungeon[rx][ry] < 25 || dungeon[rx][ry] > 28) && i < 100) {
while ((dungeon[rx][ry] < 25 || dungeon[rx][ry] > 28) && i < 100) { /// BUGFIX: OOB `while (ry < DMAXY && (`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the BUGFIX comment cut short? It ends with && (

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was meant to sign that it should just continue as previously
`while (ry < DMAXY && (dungeon[rx][ry] < 25 || dungeon[rx][ry] > 28) && i < 100) {v

@mewmew
Copy link
Contributor

mewmew commented Aug 4, 2021

Is this ready for merge?

@AJenbo
Copy link
Member Author

AJenbo commented Aug 4, 2021

I need to go over the comments and also fix the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants