Reimplementation of the library #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using lazy sequences by default is too opinionated. They incur a lot of overhead and are tricky to manage. Rather, we can expose a mechanism similar to `ocaml-h2` that uses a `schedule_read` function expecting two callbacks.
(for already closed stream) anmonteiro/ocaml-h2#175
When multiple messages are batched and read into the buffer, only the first message was extracted. Remaining messages would not be extracted until the next invocation of `on_read`.
This was referenced Apr 16, 2024
Closed
|
@wokalski if you use Edit, got confused with my compiler versions. |
|
statmemprof ftw!!! |
|
@tmcgilchrist will statmemprof be available in 5.2 or only in 5.3? |
|
Only in 5.3. Based on this libraries dependencies it should be possible to build against that version. |
|
just a little update - we are using this on production and we will probably push the final commits to this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a reimplementation of the library. Only the
eiovariant works for now. The goal of the reimplementation is to make it more:Building an opinionated workflow is not a part of this library, I will implement it in a separate library.
TODO
Bigstringafdirectly to avoid copying. string variants can be put on top for those who need them simply in the userspace. The string variants impede the performance due to excessive copying.extrapart for example)'ctxto server request handlers. Not sure if it's needed - maybe can be done in the user space, maybe has to be a part of the library - will experiment with it.