Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pagination): Performance optimization - DIA-74957 #221

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat(pagination): Performance optimization - DIA-74957 #221

wants to merge 4 commits into from

Conversation

ghostishev
Copy link

@ghostishev ghostishev commented Oct 29, 2024 •
edited by jira bot
Loading

Problem

TBD

Solution

TBD

Related

Validation

TBD

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.34%. Comparing base (2f66edf) to head (c80e3fb).

Files with missing lines Patch % Lines
fastapi_sqla/async_pagination.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2f66edf) and HEAD (c80e3fb). Click for more details.

HEAD has 48 uploads less than BASE
Flag BASE (2f66edf) HEAD (c80e3fb)
.10-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0
.12-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0
.10-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0
.11-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0
.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0
.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0
.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0
.12-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0
.9-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0
.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0
.10-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0
.11-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0
.12-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0
.9-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0
.11-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0
.9-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0
.10-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0
.9-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0
.10-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0
.12-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0
.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0
.9-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0
.11-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0
.9-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0
.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0
.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0
.9-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0
.12-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0
.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0
.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0
.11-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0
.11-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0
.12-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0
.10-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0
.11-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0
.10-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0
.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0
.11-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0
.12-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0
.9-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0
.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0
.12-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0
.10-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0
.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0
.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0
.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0
.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0
.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0
Additional details and impacted files 
@@             Coverage Diff              @@
##            master     #221       +/-   ##
============================================
- Coverage   100.00%   76.34%   -23.66%     
============================================
  Files           10       10               
  Lines          519      520        +1     
  Branches        33       33               
============================================
- Hits           519      397      -122     
- Misses           0      118      +118     
- Partials         0        5        +5
Flag Coverage Δ
.10-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam ?
.10-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam ?
.10-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam ?
.10-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam ?
.10-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam ?
.10-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam ?
.10-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam ?
.10-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam ?
.10-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam ?
.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam ?
.10-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam ?
.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam ?
.10-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam ?
.11-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam ?
.11-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam ?
.11-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam ?
.11-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam ?
.11-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam ?
.11-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam ?
.11-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam ?
.11-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam ?
.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam ?
.11-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam ?
.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam ?
.11-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam ?
.12-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam ?
.12-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam ?
.12-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam ?
.12-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam ?
.12-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam ?
.12-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam ?
.12-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam ?
.12-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam ?
.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam ?
.12-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam ?
.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam ?
.12-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam ?
.9-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam ?
.9-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam ?
.9-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam ?
.9-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam 75.00% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam ?
.9-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam ?
.9-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam ?
.9-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam ?
.9-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam 74.42% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam 73.46% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam ?
.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam ?
.9-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam ?
.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam ?
.9-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam 74.03% <0.00%> (-0.15%) ⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam 73.07% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghostishev