feat(pagination): Performance optimization - DIA-74957 #221

ghostishev · 2024-10-29T11:55:00Z

Problem

TBD

Solution

TBD

Validation

TBD

codecov · 2024-10-29T11:58:15Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.34%. Comparing base (2f66edf) to head (c80e3fb).

Files with missing lines	Patch %	Lines
fastapi_sqla/async_pagination.py	0.00%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2f66edf) and HEAD (c80e3fb). Click for more details.

HEAD has 48 uploads less than BASE

Flag BASE (2f66edf) HEAD (c80e3fb)

.10-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0

.12-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0

.10-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0

.11-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0

.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0

.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0

.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0

.12-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0

.9-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0

.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0

.10-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0

.11-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0

.12-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0

.9-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0

.11-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0

.9-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam 1 0

.10-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0

.9-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam 1 0

.10-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0

.12-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0

.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0

.9-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0

.11-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0

.9-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0

.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0

.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0

.9-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0

.12-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0

.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0

.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0

.11-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0

.11-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam 1 0

.12-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam 1 0

.10-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0

.11-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0

.10-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0

.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0

.11-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam 1 0

.12-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0

.9-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam 1 0

.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0

.12-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam 1 0

.10-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam 1 0

.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0

.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam 1 0

.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam 1 0

.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam 1 0

.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam 1 0

Additional details and impacted files

@@             Coverage Diff              @@
##            master     #221       +/-   ##
============================================
- Coverage   100.00%   76.34%   -23.66%     
============================================
  Files           10       10               
  Lines          519      520        +1     
  Branches        33       33               
============================================
- Hits           519      397      -122     
- Misses           0      118      +118     
- Partials         0        5        +5

Flag	Coverage Δ
.10-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam	`?`
.10-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam	`?`
.10-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam	`?`
.10-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam	`?`
.10-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam	`?`
.10-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam	`?`
.10-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam	`?`
.10-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam	`?`
.10-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam	`?`
.10-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam	`?`
.10-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam	`?`
.10-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam	`?`
.10-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.10-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam	`?`
.11-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam	`?`
.11-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam	`?`
.11-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam	`?`
.11-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam	`?`
.11-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam	`?`
.11-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam	`?`
.11-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam	`?`
.11-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam	`?`
.11-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam	`?`
.11-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam	`?`
.11-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam	`?`
.11-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.11-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam	`?`
.12-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam	`?`
.12-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam	`?`
.12-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam	`?`
.12-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam	`?`
.12-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam	`?`
.12-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam	`?`
.12-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam	`?`
.12-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam	`?`
.12-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam	`?`
.12-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam	`?`
.12-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam	`?`
.12-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.12-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy1.4-pydantic1-asyncpg-aws_rds_iam	`?`
.9-sqlalchemy1.4-pydantic1-asyncpg-noaws_rds_iam	`?`
.9-sqlalchemy1.4-pydantic1-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy1.4-pydantic1-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy1.4-pydantic2-asyncpg-aws_rds_iam	`?`
.9-sqlalchemy1.4-pydantic2-asyncpg-noaws_rds_iam	`?`
.9-sqlalchemy1.4-pydantic2-noasyncpg-aws_rds_iam	`75.00% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy1.4-pydantic2-noasyncpg-noaws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-pydantic1-asyncpg-aws_rds_iam	`?`
.9-sqlalchemy2.0-pydantic1-asyncpg-noaws_rds_iam	`?`
.9-sqlalchemy2.0-pydantic1-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-pydantic1-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-pydantic2-asyncpg-aws_rds_iam	`?`
.9-sqlalchemy2.0-pydantic2-asyncpg-noaws_rds_iam	`?`
.9-sqlalchemy2.0-pydantic2-noasyncpg-aws_rds_iam	`74.42% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-pydantic2-noasyncpg-noaws_rds_iam	`73.46% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-aws_rds_iam	`?`
.9-sqlalchemy2.0-sqlmodel-pydantic1-asyncpg-noaws_rds_iam	`?`
.9-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic1-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-aws_rds_iam	`?`
.9-sqlalchemy2.0-sqlmodel-pydantic2-asyncpg-noaws_rds_iam	`?`
.9-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-aws_rds_iam	`74.03% <0.00%> (-0.15%)`	⬇️
.9-sqlalchemy2.0-sqlmodel-pydantic2-noasyncpg-noaws_rds_iam	`73.07% <0.00%> (-0.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hadrien · 2025-01-16T16:17:02Z

outdated -> closing

feat(pagination): Performance optimization - DIA-74957

c80e3fb

ghostishev added 3 commits October 31, 2024 14:36

with_only_columns

7f36685

add_columns

1e2034a

lint

51d9a8b

hadrien closed this Jan 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pagination): Performance optimization - DIA-74957 #221

feat(pagination): Performance optimization - DIA-74957 #221

ghostishev commented Oct 29, 2024 •

edited by jira bot

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

hadrien commented Jan 16, 2025

feat(pagination): Performance optimization - DIA-74957 #221

feat(pagination): Performance optimization - DIA-74957 #221

Conversation

ghostishev commented Oct 29, 2024 • edited by jira bot Loading

Problem

Solution

Related

Validation

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

hadrien commented Jan 16, 2025

ghostishev commented Oct 29, 2024 •

edited by jira bot

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading