Trigger Response Undeliverable #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based of dapr/proposals#66 Adds a `FailurePolicy` option to the `Job` API to allow re-triggering job which are marked as failed by the caller. Adds two types of policy; `Drop` and `Constant`. `Drop` has no retry policy, `Constant` will constantly retry the job trigger for a configurable delay, up to a configurable maximum number of retries (which could be infinite). Note that the failure policy retry cadence has no effect on the actual Job schedule, meaning if a job was to be retired and eventually succeeded, the Job would continue to trigger at the origin configured schedule. By default, all Jobs will have a `Constant` policy with a delay of 1s. Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Adds a public API `TriggerResponse` proto message which is now returned from the Trigger function call. This message contains a Result enum which encompasses signalling the existing SUCCESS and FAILURE job trigger results, as well as a new UNDELIVERABLE result. It can be the case that a job hasn't necessarily failed, but it actually just can't be delivered to the target at this time. To prevent the Job going into a failure loop, receiving the `UNDELIVERABLE` result will put the job into a new "staging" queue. This puts the job into a holding pattern until it can be delivered. The consumer can use the new `DeliverablePrefixes` call to register the set of prefixes whose matching job names can be delivered. The returned `CancelFunc` is used to de-register this prefix. Prefixes are registered as a pool in that multiple identical prefixes can be registered and which will remain active until all are de-registered via cancellation. Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
JoshVanL
force-pushed
the
queue-staging-undeliverable-2
branch
from
3750e07 to
aabed73
Compare
cicoyle
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a public API TriggerResponse proto message which is now returned
from the Trigger function call. This message contains a Result enum
which encompasses signalling the existing SUCCESS and FAILURE job
trigger results, as well as a new UNDELIVERABLE result.
It can be the case that a job hasn't necessarily failed, but it actually
just can't be delivered to the target at this time. To prevent the Job
going into a failure loop, receiving the UNDELIVERABLE result will put
the job into a new "staging" queue. This puts the job into a holding
pattern until it can be delivered.
The consumer can use the new DeliverablePrefixes call to register the
set of prefixes whose matching job names can be delivered. The returned
CancelFunc is used to de-register this prefix. Prefixes are registered
as a pool in that multiple identical prefixes can be registered and
which will remain active until all are de-registered via cancellation.