Add "--group-domains" option #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to group all subdomains of the certificate into a single command on the challenge verification step.
Currently the user needs to do a lot of round-trips between the primary terminal where
sign_csr.pyruns and the other terminals if the certificate includes a lot of subdomains. To be precise, the number of round trips is2 + <number of subdomains>. This quickly becomes unwieldy as the number of subdomains grows. With the new--group-domainsoption the user only needs to do 3 round trips regardless of the number of domains. The old code-path is left untouched to support the use case when subdomains point to different servers.Unfortunately I had to extract a couple of functions to reduce code duplication and thus compromised the simplicity of the script somewhat. Hopefully this won't be the issue that prevents the PR to land :-)