Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from paritytech:master #25

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Commits on Nov 21, 2024

  1. github/workflows: add ARM macos build binaries job (#6427)

    # Description
    
    This PR adds the required changes to release `polkadot`,
    `polkadot-parachain` and `polkadot-omni-node` binaries built on Apple
    Sillicon macos.
    
    ## Integration
    
    This addresses requests from the community for such binaries: #802, and
    they should be part of the Github release page.
    
    ## Review Notes
    
    Test on paritytech-stg solely focused on macos binaries:
    https://github.com/paritytech-stg/polkadot-sdk/actions/runs/11824692766/job/32946793308,
    except the steps related to `pgpkms` (which need AWS credentials,
    missing from paritytech-stg). The binary names don't have a `darwin-arm`
    identifier, and conflict with the existing x86_64-linux binaries. I
    haven't tested building everything on `paritytech-stg` because the
    x86_64-linux builds run on `unbutu-latest-m` which isn't enabled on
    `pairtytech-stg` (and I haven't asked CI team to enable one), so testing
    how to go around naming conflicts should be covered next.
    
    ### TODO
    
    - [x] Test the workflow start to end (especially the last bits related
    to uploading the binaries on S3 and ensuring the previous binaries and
    the new ones coexist harmoniously on S3/action artifacts storage without
    naming conflicts) @EgorPopelyaev
    - [x] Publish the arm binaries on the Github release page - to clarify
    what's needed @iulianbarbu . Current practice is to manually publish the
    binaries built via `release-build-rc.yml` workflow, taken from S3. Would
    be great to have the binaries there in the first place before working on
    automating this, but I would also do it in a follow up PR.
    
    ### Follow ups
    
    - [ ] unify the binaries building under
    `release-30_publish_release_draft.yml` maybe?
    - [ ] automate binary artifacts upload to S3 in
    `release-30_publish_release_draft.yml`
    
    ---------
    
    Signed-off-by: Iulian Barbu <[email protected]>
    Co-authored-by: EgorPopelyaev <[email protected]>
    iulianbarbu and EgorPopelyaev authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1f7765b View commit details
    Browse the repository at this point in the history
  2. [Fix|NominationPools] Only allow apply slash to be executed if the sl…

    …ash amount is atleast ED (#6540)
    
    This change prevents `pools::apply_slash` from being executed when the
    pending slash amount of the member is lower than the ED.
    
    The issue came to light with the failing [benchmark
    test](https://github.com/polkadot-fellows/runtimes/actions/runs/11879471717/job/33101445269?pr=490#step:11:765)
    in Kusama. The problem arises from the inexact conversion between points
    and balance. Specifically, when points are converted to balance and then
    back to points, rounding can introduce a small discrepancy between the
    input and the resulting value. This issue surfaced in Kusama due to its
    ED being different from Westend and Polkadot (1 UNIT/300), making the
    rounding issue noticeable.
    
    This fix is also significant because applying a slash is feeless and
    permissionless. Allowing super small slash amounts to be applied without
    a fee is undesirable. With this change, such small slashes will still be
    applied but only when member funds are withdrawn.
    
    ---------
    
    Co-authored-by: Dónal Murray <[email protected]>
    Ank4n and seadanda authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    bf20a9e View commit details
    Browse the repository at this point in the history
  3. parachain-template-node: add properties for dev chain-spec (#6560)

    # Description
    
    Reused as before the `properties` variable when defining a development
    chain spec for parachain-template-node.
    
    ## Integration
    
    N/A
    
    ## Review Notes
    
    One line change, pretty self explanatory (it got lost within the history
    of changes over the parachain-template-node/chain_spec.rs file). To be
    honest, not really sure how useful it is, but I had the choice of
    removing the `properties` var or reuse it as before, and I went with the
    latter.
    
    Signed-off-by: Iulian Barbu <[email protected]>
    iulianbarbu authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6d59c3b View commit details
    Browse the repository at this point in the history
  4. [pallet-revive] Support all eth tx types (#6461)

    Add support for all eth tx types
    Note that js libs will continue to use the Legacy type since we don't
    include base_fee_per_gas yet in the block.
    We can think about setting these values after we revisit how we encode
    the gas into weight & deposit_limit in a follow up PR
    
    ---------
    
    Co-authored-by: Alexander Theißen <[email protected]>
    Co-authored-by: GitHub Action <[email protected]>
    3 people authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d8ce550 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Adds BlockNumberProvider in multisig, proxy and nft pallets (#5723)

    Step in #3268
    
    This PR adds the ability for these pallets to specify their source of
    the block number. This is useful when these pallets are migrated from
    the relay chain to a parachain and vice versa.
    
    This change is backwards compatible:
    1. If the `BlockNumberProvider` continues to use the system pallet's
    block number
    2. When a pallet deployed on the relay chain is moved to a parachain,
    but still uses the relay chain's block number
    
    However, we would need migrations if the deployed pallets are upgraded
    on an existing parachain, and the `BlockNumberProvider` uses the relay
    chain block number.
    
    ---------
    
    Co-authored-by: Kian Paimani <[email protected]>
    gupnik and kianenigma authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7c5224c View commit details
    Browse the repository at this point in the history
  2. Only mess with coretime if we are registering an actual parachain. (#…

    …6554)
    
    Co-authored-by: Robert <[email protected]>
    Co-authored-by: ordian <[email protected]>
    3 people authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    08ec8cd View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. Notify telemetry only every second about the tx pool status (#6605)

    Before this was done for every imported transaction. When a lot of
    transactions got imported, the import notification channel was filled.
    The underlying problem was that the `status` call is read locking the
    `validated_pool` which will be write locked by the internal submitting
    logic. Thus, the submitting and status reading was interferring which
    each other.
    
    ---------
    
    Co-authored-by: GitHub Action <[email protected]>
    bkchr and actions-user authored Nov 24, 2024
    Configuration menu
    Copy the full SHA
    1e3b8e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Fixes cfg attributes in runtime macro (#6410)

    Fixes #6209
    
    This PR adds the support for cfg attributes in the runtime macro.
    
    ---------
    
    Co-authored-by: Bastian Köcher <[email protected]>
    gupnik and bkchr authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6da7d36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    75e79fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e709c9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c422d8b View commit details
    Browse the repository at this point in the history
  5. remove ReportCollator message (#6628)

    Closes #6415 
    
    # Description
    
    Remove unused message `ReportCollator` and test related to this message
    on the collator protocol validator side.
    
    cc: @tdimitrov
    
    ---------
    
    Co-authored-by: Tsvetomir Dimitrov <[email protected]>
    Co-authored-by: command-bot <>
    jpserrat and tdimitrov authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    41b6915 View commit details
    Browse the repository at this point in the history
  6. rpc server: fix subscription id_provider being reset to default one. (#…

    …6588)
    
    # Description
    
    The PR ensures that the id_provider variable is cloned instead of taken,
    which can help prevent issues related id provider being reset to the
    default.
    
    In [a test in
    moonbeam](https://github.com/moonbeam-foundation/moonbeam/blob/c6d07d703dfcdd94cc311fa83b553071b7d433ff/test/suites/dev/moonbase/test-subscription/test-subscription.ts#L20-L31)
    we found that the id_provider is being reset somehow and changed to the
    default one. Changing .take() to .clone() would fix the issue.
    
    
    # Checklist
    
    * [x] My PR includes a detailed description as outlined in the
    "Description" and its two subsections above.
    * [ ] My PR follows the [labeling requirements](
    
    https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process
    ) of this project (at minimum one label for `T` required)
    * External contributors: ask maintainers to put the right label on your
    PR.
    * [ ] I have made corresponding changes to the documentation (if
    applicable)
    * [ ] I have added tests that prove my fix is effective or that my
    feature works (if applicable)
    
    ---------
    
    Co-authored-by: Niklas Adolfsson <[email protected]>
    TarekkMA and niklasad1 authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6d5f814 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. bump zombienet-sdk version v0.2.16 (#6633)

    Fix #6575.
    
    cc: @iulianbarbu
    
    Co-authored-by: Iulian Barbu <[email protected]>
    pepoviola and iulianbarbu authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7f64e66 View commit details
    Browse the repository at this point in the history
  2. Bump rustls from 0.23.14 to 0.23.18 (#6641)

    Bumps [rustls](https://github.com/rustls/rustls) from 0.23.14 to
    0.23.18.
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/rustls/rustls/commit/33af2c38b0f1e4abf44d59d5b74ccf12f5cf5e56"><code>33af2c3</code></a>
    Prepare 0.23.18</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/ffe646d1ff07d3e1d9f009daadd94228d462425d"><code>ffe646d</code></a>
    Add reproducer for bug 2227</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/69b6f7473a7ae096a9cf9e2d6eb3cd8b22743597"><code>69b6f74</code></a>
    Record and restore the processed cursor in first_handshake_message</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/4ef3532cf2fceda9fdd19947f871adf7020d0b49"><code>4ef3532</code></a>
    Upgrade to mio 1</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/092a16427e81e58ecd6bcfdacc0b49f02bad8db3"><code>092a164</code></a>
    Manage dependencies via the workspace</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/a01bd6bcb536c6cdd490942b0eae2903abcfcab3"><code>a01bd6b</code></a>
    rustls-bench: fix warnings with no features</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/7d74de2c1bdf265531036f50abd3fc04df8c148a"><code>7d74de2</code></a>
    tests: linearize new test code helper</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/499d797b267e0b548fef5225b044b99fc215a8ff"><code>499d797</code></a>
    fix: do not send session_ticket(35) extension for TLS 1.3</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/faca28904efcb3b5a4a5f05be8e03374bf5086df"><code>faca289</code></a>
    chore(deps): lock file maintenance</li>
    <li><a
    href="https://github.com/rustls/rustls/commit/d12f42385c2da74e1ec16826af68d17a13101152"><code>d12f423</code></a>
    fix(deps): update rust crate asn1 to 0.20</li>
    <li>Additional commits viewable in <a
    href="https://github.com/rustls/rustls/compare/v/0.23.14...v/0.23.18">compare
    view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility
    score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rustls&package-manager=cargo&previous-version=0.23.14&new-version=0.23.18)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't
    alter it yourself. You can also trigger a rebase manually by commenting
    `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits
    that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after
    your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge
    and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating
    it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all
    of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop
    Dependabot creating any more for this major version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop
    Dependabot creating any more for this minor version (unless you reopen
    the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop
    Dependabot creating any more for this dependency (unless you reopen the
    PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the
    [Security Alerts
    page](https://github.com/paritytech/polkadot-sdk/network/alerts).
    
    </details>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    86a917f View commit details
    Browse the repository at this point in the history
  3. ci/check-semver: Fix semver failed step (#6535)

    The semver-check is failing with the following
    [error](https://github.com/paritytech/polkadot-sdk/actions/runs/11908981132/job/33185572284):
    
    ```bash
    error[E0658]: use of unstable library feature 'error_in_core'
      --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-decode-0.5.0/src/decoding/extrinsic_decoder.rs:56:6
       |
    56 | impl core::error::Error for ExtrinsicDecodeError {}
       |      ^^^^^^^^^^^^^^^^^^
       |
       = note: see issue #103765 <rust-lang/rust#103765> for more information
       = help: add `#![feature(error_in_core)]` to the crate attributes to enable
       = note: this compiler was built on 2024-05-31; consider upgrading it if it is out of date
    ```
    
    This is related to the toolchain nightly version 1.80. In rust, 1.81 the
    `core::error::Error` is stable.
    
    After updating the rust-toolchain, parity-publish crate must be updated
    as well.
    The `cargo-semver-checks` dependency of `parity-publish` crate is
    updated from 0.34 to 0.38.
    This update enables rustdoc v36 that fixes the following
    [issue](https://github.com/paritytech/polkadot-sdk/actions/runs/11912689841/job/33196936011):
    
    
    ```bash
     validating prdocs...
    checking file changes...
    checking semver changes...
    (1/18) building frame-support-HEAD...
    (2/18) building frame-support-28.0.0...
    Error: rustdoc format v36 for file /__w/polkadot-sdk/polkadot-sdk/target/doc/frame_support.new is not supported
    ```
    
    This PR is pending on a release of parity-publish to version 0.9.0
    (fixes already on origin/master)
    
    ---------
    
    Signed-off-by: Alexandru Vasile <[email protected]>
    lexnv authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8216235 View commit details
    Browse the repository at this point in the history
  4. [Release|CI/CD] Github pipeline to publish polkadot deb package (#6640)

    This pipeline should replace a manual action done on the `cleamroom`
    server to publish the `polkadot` deb package to our apt repo with the
    pipeline triggered from the new paritytech-release org.
    Right now, this is done manually by running the
    [add-packages.sh](https://github.com/paritytech/cleanroom/blob/master/ansible/roles/parity-repos/files/add-packages.sh)
    script on the `cleanroom` machine.
    What is done under the hood:
    - Pipeline downloads `polakdot` deb package from S3, that was prebuilt
    in the [Build release rc
    pipeline](https://github.com/paritytech/polkadot-sdk/blob/master/.github/workflows/release-build-rc.yml)
    - Prepares and syncs local apt repository
    - Adds and signs deb package to it using `reprepro`
    - Uploads new deb package to the distributed repo
    
    Closes: paritytech/release-engineering#239
    EgorPopelyaev authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3c00387 View commit details
    Browse the repository at this point in the history
  5. xcm: fix local/remote exports when inner routers return `NotApplicabl…

    …e` (#6645)
    
    This PR addresses two small fixes:  
    
    1. Fixed a typo ("as as") found on the way.  
    2. Resolved a bug in the `local/remote exporters` used for bridging.
    Previously, they consumed `dest` and `msg` without returning them when
    inner routers/exporters failed with `NotApplicable`. This PR ensures
    compliance with the
    [`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450)
    and
    [`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45)
    traits.
    
    ---------
    
    Co-authored-by: GitHub Action <[email protected]>
    bkontur and actions-user authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1c0b610 View commit details
    Browse the repository at this point in the history
  6. Zero refund check for FungibleAdapter (#6506)

    `FungibleAdapter` will now check if the _refund amount_ is zero before
    calling deposit & emitting an event.
    
    Fixes #6469.
    
    ---------
    
    Co-authored-by: GitHub Action <[email protected]>
    Dinonard and actions-user authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f520adb View commit details
    Browse the repository at this point in the history
  7. Hide nonce implementation details in metadata (#6562)

    See polkadot-fellows/runtimes#248 : using
    `TypeWithDefault` having derived `TypeInfo` for `Nonce` causes a
    breaking change in metadata for nonce type because it's no longer `u64`.
    
    Adding a default implementation of `TypeInfo` for `TypeWithDefault` to
    restore the original type info in metadata.
    
    ---------
    
    Co-authored-by: Kian Paimani <[email protected]>
    re-gius and kianenigma authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    fc315ac View commit details
    Browse the repository at this point in the history