Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network-Score : Add Test for RatingIdentierNotFound #501

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Network-Score : Add Test for RatingIdentierNotFound #501

merged 2 commits into from
Sep 4, 2024

Conversation

zeel991
Copy link
Contributor

@zeel991 zeel991 commented Aug 14, 2024

@zeel991 zeel991 marked this pull request as ready for review August 14, 2024 19:38
@zeel991
Copy link
Contributor Author

zeel991 commented Aug 23, 2024

@vatsa287 Can you please give your feedback on the PR

vatsa287
vatsa287 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vatsa287 vatsa287 requested a review from amarts August 27, 2024 04:50
@amarts amarts merged commit d93c5a2 into dhiway:develop Sep 4, 2024
3 checks passed
@VedantKhairnar
Copy link

Hello @zeel991 ,
Thanks for your contribution.
As part of Augtoberfest, we want to reward you for your contributions, so pls fill out this form by 19th Sept.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarts amarts amarts approved these changes

@vatsa287 vatsa287 vatsa287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C4GT] Network-Score: Add tests for RatingIdentifierNotFound
4 participants
@zeel991 @VedantKhairnar @amarts @vatsa287