Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for Unauthorization Operation #442

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

VishnuAmit
Copy link

@VishnuAmit VishnuAmit commented May 6, 2024

Hi, @vatsa287. I have deleted the previous PR and created this new which solves this issue. The test cases are passing now.
Kindly take a look into it.
Kind Regards.

image

@VishnuAmit
Copy link
Author

hey @zeel991 . Can you please review it and approve the workflow.
Kind Regards

Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VishnuAmit This test is for AuthorisationNotFound which has already been implemented through #439.
For UnauthorizedOperation please check issue() extrinsic where this error code is getting hit.

@VishnuAmit
Copy link
Author

@vatsa287 yes..it was solved through #439 .But I raised PR for this before 439 and due to unnecessary files(bin n log files) in the changes. I had to create a new PR to remove all those files.

I'll look into it. (Issue().extrinsic). And also I'd like to see if it's passing the test cases here. Ie approval of workflow.

Thanks

@zeel991
Copy link
Contributor

zeel991 commented May 9, 2024

@vatsa287 yes..it was solved through #439 .But I raised PR for this before 439 and due to unnecessary files(bin n log files) in the changes. I had to create a new PR to remove all those files.

I'll look into it. (Issue().extrinsic). And also I'd like to see if it's passing the test cases here. Ie approval of workflow.

Thanks

Run the command

rustfmt tests.rs 

This will help you clear the rustfmt check , also , you can check whether your test works or not locally using the command

cargo test --release --locked --features=runtime-benchmarks --no-fail-fast --verbose --color always --lib --package pallet-asset

This will help you figure out the errors locally for further tests .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants