Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages/did: throw an error if space already exists #233

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

adi-a11y
Copy link
Contributor

@adi-a11y adi-a11y commented Aug 7, 2024

This pull request addresses an issue where the SDK did not throw an error if a chainspace was already present. The fix ensures that attempting to create a chainspace that already exists will now result in an appropriate error being thrown.This pull request addresses an issue where the SDK did not throw an error if a chainspace was already present. The fix ensures that attempting to create a chainspace that already exists will now result in an appropriate error being thrown.

Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarts amarts merged commit f38093c into dhiway:develop Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants