Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages/did: Add keyType Parameter to createDid Method #226

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

adi-a11y
Copy link
Contributor

No description provided.

@adi-a11y adi-a11y changed the title Package/did: Add keyType Parameter to createDid Method Packages/did: Add keyType Parameter to createDid Method Jun 20, 2024
@adi-a11y adi-a11y requested review from amarts and vatsa287 June 20, 2024 06:16
Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

packages/did/src/Did.chain.ts Outdated Show resolved Hide resolved
packages/did/src/Did.chain.ts Show resolved Hide resolved
Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarts amarts merged commit f0a3a86 into dhiway:develop Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants