Package updates & Network Membership #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried this with dhiway/cord#223 and was able to run the demo successfully. |
smohan-dw
changed the title
amarts
approved these changes
Sep 19, 2023
| @@ -47,7 +47,7 @@ export async function createDid( | |||
| await Cord.Chain.signAndSubmitTx(didCreationTx, submitterAccount) | |||
|
|
|||
| const didUri = Cord.Did.getDidUriFromKey(authentication) | |||
| const encodedDid = await api.call.did.query(Cord.Did.toChain(didUri)) | |||
| const encodedDid = await api.call.didApi.query(Cord.Did.toChain(didUri)) | |||
There was a problem hiding this comment.
@Vikastc @ujjwal6792 Please note this change. With the cord.js upgrade, this would be impacting the cord-apis repo.
| @@ -12,7 +12,7 @@ export async function getDidDocFromName( | |||
| console.log(`\n❄️ Resolve DID name ${didName} `) | |||
|
|
|||
| // Query the owner of the provided didName. | |||
| const encodedDidNameOwner = await api.call.did.queryByName(didName) | |||
| const encodedDidNameOwner = await api.call.didApi.queryByName(didName) | |||
There was a problem hiding this comment.
@Vikastc @ujjwal6792 same here, impact on cord-apis repo.
| "glob": "^7.1.1", | ||
| "rimraf": "^3.0.2", | ||
| "ts-node": "^10.9.0", | ||
| "ts-node": "^10.4.0", |
There was a problem hiding this comment.
nitpick: this is lowering the version. All others are about increments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion - dhiway/cord#223
Breaking change - extrinsicAuthorship -> networkMembership.