Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InterpretationsFragment is unfinished. #16

Open
VladislavAlfredov opened this issue Dec 4, 2015 · 0 comments
Open

InterpretationsFragment is unfinished. #16

VladislavAlfredov opened this issue Dec 4, 2015 · 0 comments

Comments

@VladislavAlfredov
Copy link
Member

I started working on the caching for the interpretations last night, expecting that the activities and fragments are finished and working. It turnes out that they are not.

  1. The next page button is never shown.
  2. The RESTGetInterpretations used to only get page 0, and the page size was a magic number in the code (5).
  3. There is no reload button for the InterpretationsFragment.
  4. The overall class strcuture seems to be somewhat different from the InboxFragment, untested and most likely never used.

Implementing caching for the interpretations would not be difficult if they were implemented themselves.
As you can see from last 3 commits ( 36de15e, 4301169 and 9172cc6), I have not only abstracted the caching lists in RESTSessionStorage, such that the task would be simply :

  1. Implementing the wrapper functions in RESTSessionStorage in a similiar way to those for inboxFragment. Maybe one or two conditions for forcing refresh if one has commented on a interpretation.
  2. Calling these wrappers from the code (which is unfinished).
    But I also started refactoring the InterpretationsFragment...

Unfortunately I will not be able to continue with the refactoring, as I have other tasks to do.
I will also not be implementing caching, since in order to test it I would have to finish the Interpretations -REST client classes (InterpretationsFragment, RESTGetInterpretations, RestGetPicture, InterpretationCommentActivity (haven't even looked at the last one yet)).

As such I leave this as "wontfix".
I have implemented the wrappers and added todo comments or code in most of the appropriate places for caching calls. (da55bd5)

@VladislavAlfredov VladislavAlfredov added this to the Milestone 3 milestone Dec 4, 2015
@VladislavAlfredov VladislavAlfredov changed the title InterpretationsFragment is unfinished. And mostly useless. InterpretationsFragment is unfinished. Dec 15, 2015
@VladislavAlfredov VladislavAlfredov removed this from the Milestone 3 milestone Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant