fix(button): use flexbox instead of font-size to ensure the icon is centered #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
changed the title
|
|
🚀 Deployed on https://pr-1643--dhis2-ui.netlify.app |
kabaros
approved these changes
Nov 28, 2024
HendrikThePendric
deleted the
fix/icon-only-button-vertical-alignment
branch
dhis2-bot
added a commit
that referenced
this pull request
Nov 28, 2024
## [10.1.4](v10.1.3...v10.1.4) (2024-11-28) ### Bug Fixes * use flexbox instead of font-size to ensure the icon is centered ([#1643](#1643)) ([939f5fa](939f5fa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the styles that we had to center the icon were a relic of a very old implementation. I think using flexbox makes a lot more sense.