fix(select): prevent prop-types error by making tabIndex an optional prop
#1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is OK since `tabIndex` also has a default value in the component
|
|
🚀 Deployed on https://pr-1640--dhis2-ui.netlify.app |
kabaros
approved these changes
Nov 26, 2024
HendrikThePendric
deleted the
fix/make-tabindex-an-optional-prop-for-select-input-wrapper
branch
dhis2-bot
added a commit
that referenced
this pull request
Nov 26, 2024
## [10.1.2](v10.1.1...v10.1.2) (2024-11-26) ### Bug Fixes * prevent prop-types error by making tabIndex an optional prop ([#1640](#1640)) ([b57b81c](b57b81c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents a prop-types error by making
tabIndexan optional prop, which is not a problem sincetabIndexalso has a default value in the component.I originally encountered this bug in the sharing dialog-after upgrading
@dhis2/uiin the Dashboards App and was able to reproduce it bug in the "For dashboard with cascading sharing partial success" demo story. I have also been able to verify that this PR addresses the issue this way.