fix(menu-item): tweak active and focused styles #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1639--dhis2-ui.netlify.app |
HendrikThePendric
force-pushed
the
fix/remove-active-style-from-menu-item-with-tabindex-0
branch
from
b6ce9b9 to
8a52497
Compare
HendrikThePendric
force-pushed
the
fix/remove-active-style-from-menu-item-with-tabindex-0
branch
from
8a52497 to
a91c77b
Compare
|
kabaros
approved these changes
Nov 26, 2024
HendrikThePendric
changed the title
HendrikThePendric
changed the title
HendrikThePendric
deleted the
fix/remove-active-style-from-menu-item-with-tabindex-0
branch
dhis2-bot
added a commit
that referenced
this pull request
Nov 26, 2024
## [10.1.1](v10.1.0...v10.1.1) (2024-11-26) ### Bug Fixes * **menu-item:** tweak active and focused styles ([#1639](#1639)) ([e6bf884](e6bf884))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two loosely related changes:
Remove active style from menu item with tabIndex 0
Setting the active class on items with tab index 0 works nicely when using keyboard navigation but causes odd behaviour when using mouse-based interaction: a
MenuwithMenuItemscan end up having multiple "active items":By removing this code the keyboard navigation is still visually supported by the focus outline, which is enough IMO.
Fix focussed outline styles
The problem was as follows:
<a>tag<li>gets atab-indexand the<li>becomes the element that receives focusSo I've moved the focus styles from the
<a>to the<li>and everything looks better.For reference, here's a screenshot of how the focussed menu-item looked before, with the broken outline styles and the grey background:
