fix: proptype errors #607
Merged
fix: proptype errors #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-607--dhis2-scheduler.netlify.app |
ghost
marked this pull request as ready for review
kabaros
approved these changes
Mar 20, 2024
|
🎉 This PR is included in version 101.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhis2.atlassian.net/browse/DHIS2-17022
See https://final-form.org/docs/react-final-form/api/Field for the fix I used in the last commit:
There are other ways to fix it, like defaultValues or initialValues. But initialValues on a field would override the ones we set on the form, which would prevent us seeding the form with data when editing a queue. And using a defaultValue would mean the form is dirty as soon as it's initialized, which is confusing for users. The fix suggested above is not ideal, but the least bad in my opinion.