fix: add missing parameter fields #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-605--dhis2-scheduler.netlify.app |
ghost
force-pushed
the
add-missing-parameter-fields
branch
from
566746f to
5b4768d
Compare
ghost
force-pushed
the
add-missing-parameter-fields
branch
from
7a947c4 to
4b55f36
Compare
ghost
marked this pull request as ready for review
ghost
force-pushed
the
add-missing-parameter-fields
branch
from
d0853c0 to
d995fcb
Compare
Birkbjo
reviewed
Mar 15, 2024
Birkbjo
requested changes
Mar 15, 2024
There was a problem hiding this comment.
The code looks good to me!
I'm a bit confused about the change to use 42 though. If this is not supported in 41, I don't think we should release this in the app in master at all for quite some time.
(Sorry, just got a bit confused - see that this is only for the tests against dev).
Birkbjo
approved these changes
Mar 15, 2024
ghost
force-pushed
the
add-missing-parameter-fields
branch
2 times, most recently
from
1dcc212 to
55d1be5
Compare
ghost
force-pushed
the
add-missing-parameter-fields
branch
from
55d1be5 to
6540ff3
Compare
|
🎉 This PR is included in version 101.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhis2.atlassian.net/browse/DHIS2-17024
Follow up:
The requirements for the tracker search optimization job's attributes field are unclear, so that field is still missing. I've asked the tracker team. We can implement it later if necessary.
Some details on the error: relativeApiEndpoint: "/api/trackedEntityAttributes/indexable" for tracker search optimization yields: "TrackedEntityAttribute with id indexable could not be found." (created here: https://dhis2.atlassian.net/browse/DHIS2-17093)